Skip to content

feat(stovepipe): Persist terminal build ID - #754

Merged
prathshenoy merged 1 commit into
prath.shenoy/stovepipe-terminal-build-markerfrom
prath.shenoy/stovepipe-terminal-build-lookup
Sep 30, 2026
Merged

prathshenoy merged 1 commit into
prath.shenoy/stovepipe-terminal-build-markerfrom
prath.shenoy/stovepipe-terminal-build-lookup

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Persist the terminal build ID together with a request's terminal state.

Why:

  • Ensure the first terminal build also becomes the request’s recorded terminal build.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. It only stops terminal transitions from populating the nullable field; existing request state remains unchanged.

Issues

Stack

  1. feat(stovepipe): Store terminal build ID #752
  2. @ feat(stovepipe): Persist terminal build ID #754
  3. feat(stovepipe): Record terminal build history #756
  4. feat(stovepipe): Pass terminal build to resolver #757
  5. docs(stovepipe): Document terminal build IDs #758

@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from f603204 to a2ccd12 Compare September 29, 2026 01:20
@prathshenoy
prathshenoy added this pull request to stack #755 September 29, 2026 01:24
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from a2ccd12 to b746e90 Compare September 29, 2026 01:28
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from b746e90 to 5731f6d Compare September 29, 2026 01:30
@prathshenoy
prathshenoy marked this pull request as ready for review September 29, 2026 13:34
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from 5731f6d to acdbff4 Compare September 29, 2026 17:16
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from acdbff4 to c708685 Compare September 29, 2026 17:20
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from c708685 to a214d36 Compare September 29, 2026 17:27
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from a214d36 to d81a5e8 Compare September 29, 2026 22:22
@prathshenoy prathshenoy changed the title feat(stovepipe): Look up terminal builds feat(stovepipe): Persist terminal build ID Sep 29, 2026
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from d81a5e8 to 9e78080 Compare September 29, 2026 22:28
**What**:
- Record the build that completes each request with its terminal state.

**Why**:
- Preserve the winning build identity for downstream request processing.
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-lookup branch from 9e78080 to c0e823f Compare September 29, 2026 22:30
@prathshenoy
prathshenoy added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit a8368f9 Sep 30, 2026
16 checks passed
@behinddwalls
behinddwalls deleted the prath.shenoy/stovepipe-terminal-build-lookup branch September 30, 2026 00:10
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Store the build ID that establishes a request's terminal state.

**Why**:
- Make the terminal build direct request state for downstream
resolution.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. No downstream consumer needs the terminal build
identity currently.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)


## Stack

1. @ uber#752
1. uber#754
1. uber#756
1. uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Record the terminal build ID with a request's terminal history when a
build establishes the state.

**Why**:
- Preserve durable history showing which build established the request’s
final state.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. Terminal history is supplementary and does not change
request state or project resolution.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. uber#754
1. @ uber#756
1. uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Provide the terminal build ID when resolving project validation
results.

**Why**:
- Let repository-specific resolution use artifacts from the build that
established the request state.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. It only stops project resolution from receiving the
terminal build ID; request state and history remain unchanged.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. uber#754
1. uber#756
1. @ uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Document how a terminal build ID is stored on a request and provided
to project resolution.

**Why**:
- Keep the RFC aligned with the request-side terminal-build behavior.

## Test Plan

- [x] Ask an agent to find inconsistencies between the docs and the
code.

## Revert Plan

- Revert this PR. The changes in this PR include documentation only.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)


## Stack

1. uber#752
1. uber#754
1. uber#756
1. uber#757
1. @ uber#758

This branch was successfully deployed

1 active deployment
stack-rebase — c0e823f6 Deployed Sep 30, 2026 by prathshenoy via Rebase Stack #544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants